tell mysql to ignore the sort index for search queries#29300
Closed
icewind1991 wants to merge 2 commits intomasterfrom
Closed
tell mysql to ignore the sort index for search queries#29300icewind1991 wants to merge 2 commits intomasterfrom
icewind1991 wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
mysql really likes to pick an index for sorting if it can't fully satisfy the where filter with an index, since search queries pretty much never are fully filtered by index mysql often picks an index for sorting instead of the *much* more useful index for filtering. To bypass this, we tell mysql explicitly not to use the mtime (the default order field) index, so it will instead pick an index that is actually useful. Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
added
3. to review
Member
Author
|
/backport to stable22 |
skjnldsv
requested review from
a team,
CarlSchwan and
come-nc
and removed request for
a team
PVince81
reviewed
Oct 21, 2021
| $this->add('join', [ | ||
| $this->quoteAlias($name) => [ | ||
| // horrible query builder crimes to sneak in raw sql after the "FROM oc_filecache $name" | ||
| 'joinType' => $mysqlIndexHint . ' left', |
Member
There was a problem hiding this comment.
what would be a clean way ? is this something that could be added upstream ?
Member
Author
There was a problem hiding this comment.
It would have to be added upstream (the design of the query builder doesn't really make it possible to overwrite internal parts of it) but upstream is (understandably) hesitant about adding features that only apply on one specific db backend.
While this is certainly not a nice way to do this, it is the best option I'm aware of and doesn't require waiting for upstream releases.
skjnldsv
added
2. developing
This was referenced Nov 23, 2021
Member
|
Bump? What is the status? |
Merged
Merged
Member
Author
|
replaced with #32074 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Involves some creative query builder usage to sneak the index hint into the query
mysql really likes to pick an index for sorting if it can't fully satisfy the where
filter with an index, since search queries pretty much never are fully filtered by index
mysql often picks an index for sorting instead of the much more useful index for filtering.
To bypass this, we tell mysql explicitly not to use the mtime (the default order field) index,
so it will instead pick an index that is actually useful.